Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: update nginxC.Terminate #627

Merged
merged 1 commit into from
Nov 17, 2022
Merged

README: update nginxC.Terminate #627

merged 1 commit into from
Nov 17, 2022

Conversation

ofey404
Copy link
Contributor

@ofey404 ofey404 commented Nov 17, 2022

This is a documentation enhancement.

What does this PR do?

Fix an outdated method in README.md

Environment: go 1.19.3, testcontainers-go v0.15.0.

Why is it important?

Most users would grab this example for test. So, it should work out of the box.

Related issues

Too tiny to create an issue.

@ofey404 ofey404 requested a review from a team as a code owner November 17, 2022 11:56
@mdelapenya mdelapenya self-assigned this Nov 17, 2022
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Nov 17, 2022
mdelapenya
mdelapenya approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this super tiny and super valuable change @ofey404!

LGTM!

@mdelapenya mdelapenya merged commit eb22bbd into testcontainers:main Nov 17, 2022
mdelapenya referenced this pull request in mdelapenya/testcontainers-go Nov 17, 2022
@mdelapenya
Merge branch 'main' into examples-work
bc0ec00 
* main:
  docs: update method to `nginxC.Terminate` (#627)
  fix: do not prepend garbage in the container.Exec response (#624)
  chore: retire podman pipeline (#625)
  update gotest.md - fix errors in the example (#623)
  chore: sync governance files (#622)
@mdelapenya mdelapenya mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
documentation Docs, docs, docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofey404 @mdelapenya